Support the conversion of JsonObject to custom types #476
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, let me have a look. |
|
@sberyozkin started some work on this. The API looks like this: What do you think? |
|
@radcortez Thanks Roberto, I'll try to experiment in the next few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Roberto, @radcortez, this is another draft PR, focusing for now on
JsonWebToken.getClaim(String name)and the conversion of complex claims to start with, it can be aligned somehow with your PR where an individual claim injection is supported.The immediate issue is that it is only
Converter<T>.convert(String)at the moment, can you please update it to have 2 type variables for the input toconvertbe customized as needed ?thanks